fix(reset-data): the argument --network-peer-store
couldn't work
#2950
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The argument
--network-peer-store
for the sub-commandreset-data
couldn't work.Because the path of
network/peer-store
is a directory but using a method which removes files to delete it.Return code is
0
when has errors.Prompt to remove a empty path.
Check List
Tests
Manual test (add detailed scripts or steps below)
ckb init --chain dev -C dev
Check 1:
ckb reset-data -C dev
: returns0
immediately without prompt.ckb run -C dev
andCtrl-C
after 10 seconds.Check 2:
ls dev/data/network/peer_store
: the directory should exists.ckb reset-data -C dev --force --network-peer-store
: returns0
immediately without prompt.ls dev/data/network/peer_store
: the directory should be removed.rm dev/data/network/secret_key
mkdir dev/data/network/secret_key
Check 3:
ckb reset-data -C dev --force --network-secret-key
: returns>0
immediately without prompt.Release note