fix: fix stream body read #2934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quake
reviewed
Aug 11, 2021
driftluo
force-pushed
the
fix-miner-stream-body-read
branch
from
0363d3e
to
def7474
Compare
zhangsoledad
approved these changes
Aug 11, 2021
quake
approved these changes
Aug 11, 2021
|
bors r=zhangsoledad,quake |
|
Build succeeded: |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP body is a stream, it can't be read all by once.
We need to use streaming to read it completely, otherwise, the miner will not be able to obtain the block template correctly when the transaction volume is large.