Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove impl cell_provider on store #2914

Merged
merged 1 commit into from
Sep 10, 2021
Merged

refactor: remove impl cell_provider on store #2914

merged 1 commit into from
Sep 10, 2021
+72 −61

Conversation

zhangsoledad
Copy link
Member

@zhangsoledad zhangsoledad commented Aug 9, 2021 •
edited
Loading

What problem does this PR solve?

In principle，we should only impl cell_provider on snapshot, not the store directly.

What is changed and how it works?

Remove impl cell_provider on store

Release note 

Title Only: Include only the PR title in the release note.

@zhangsoledad zhangsoledad force-pushed the zhangsoledad/remove_impl_cell_provider_on_store branch from 8cbd313 to 7577d59 Compare September 3, 2021 05:28
@zhangsoledad zhangsoledad marked this pull request as ready for review September 3, 2021 05:32
@zhangsoledad zhangsoledad requested a review from a team as a code owner September 3, 2021 05:32
@quake
Copy link
Member

quake commented Sep 10, 2021

bors r=quake,doitian

@bors
Copy link
Contributor

bors bot commented Sep 10, 2021

Build succeeded:

@bors bors bot merged commit ccb442b into nervosnetwork:develop Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian approved these changes

@quake quake quake approved these changes

@keroro520 keroro520 Awaiting requested review from keroro520

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangsoledad @quake @doitian