Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: there may be competition between header sync and eviction #2894

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

driftluo
Copy link
Collaborator

@driftluo driftluo commented Aug 2, 2021

relation:#2857

The last PR left a problem. There may be a race condition between the two actions. Before reducing n_sync_started, we need to determine whether it is in the Started state.

This PR will backport to 0.43

@driftluo driftluo requested a review from a team as a code owner August 2, 2021 09:44
@driftluo
Copy link
Collaborator Author

driftluo commented Aug 2, 2021

bors r=yangby-cryptape, quake

@bors
Copy link
Contributor

bors bot commented Aug 2, 2021

Build succeeded:

@bors bors bot merged commit ab449d5 into nervosnetwork:develop Aug 2, 2021
@driftluo driftluo deleted the remove-wrong-assert branch August 2, 2021 12:16
@doitian doitian mentioned this pull request Aug 10, 2021
3 tasks
@doitian doitian mentioned this pull request Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants