feat(hardfork): ckb2021 hardfork features #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure load_cell_data_hash is consistent with the load_cell_data behavior
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…nto branch ckb2021-develop
yangby-cryptape
force-pushed
the
ckb2021-develop
branch
from
fb0fbea
to
f70a3e8
Compare
yangby-cryptape
requested review from
doitian,
keroro520,
quake and
zhangsoledad
as code owners
quake
reviewed
Jun 4, 2021
|
I will apply all request changes at last in one commit. |
…elative since start timestamp
…cation and add a unit test
yangby-cryptape
removed
the
s:waiting-on-author
quake
previously approved these changes
Jun 11, 2021
yangby-cryptape
force-pushed
the
ckb2021-develop
branch
from
74453a7
to
30360a2
Compare
quake
previously approved these changes
Jun 11, 2021
quake
previously approved these changes
Jun 11, 2021
quake
approved these changes
Jun 14, 2021
zhangsoledad
approved these changes
Jun 15, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 15, 2021
2715: feat(hardfork): ckb2021 hardfork features r=yangby-cryptape a=yangby-cryptape ### Suggestions for Review **The best way to review this PR is reviewing each commit independently.** ### Brief introduction for Commits #### New hardfork Features **All following features can be found in RFC PRs.** - feat(hardfork): in the "since epoch", the index should be less than length Ref: [CKB-RFCs PR 223: Ensure that index < length in input since field using epoch](nervosnetwork/rfcs#223) - feat(hardfork): use block timestamp of input cells as relative since start timestamp Ref: [CKB-RFCs PR 221: Use Block Timestamp as Start Timestamp in Since](nervosnetwork/rfcs#221) - **[Reverted]** ~~feat(hardfork): allow unknown block versions and transactions versions~~ ~~Ref: [CKB-RFCs PR 230: Allow unknown tx & block version](nervosnetwork/rfcs#230 - feat(hardfork): allow script multiple matches on identical data for type hash-type scripts Ref: [CKB-RFCs PR 222: Allow script multiple matches on identical code](nervosnetwork/rfcs#222) - feat(hardfork): reuse the uncles hash in the header as the extra hash Ref: [CKB-RFCs PR 224: Add a variable length field in the block header](nervosnetwork/rfcs#224) - **[Reverted]** ~~feat(hardfork): allow loading uncommitted cell data hashes from tx pool~~ ~~Ref: [CKB-RFCs PR 228: ckb2021: fix load_cell_data_hash syscall](nervosnetwork/rfcs#228 #### Other Important Commits - feat(hardfork): setup the components for hard fork features - refactor: let verifiers know the real environment that the transaction is in Almost all features require this refactor commit. - refactor: remove useless parameter "with_data" because it always be true (tricky) So I can change less APIs and less code to apply the feature: allow loading uncommitted cell data hashes from tx pool. ### About Tests Almost all features have detailed integration tests (or unit tests): - Many blocks before hardfork; - Only one block before hardfork; - The block at hardfork; - Many blocks after hardfork. All commits can passed all integration tests and unit tests. Co-authored-by: zhangsoledad <[email protected]> Co-authored-by: Boyu Yang <[email protected]>
|
bors r=quake,doitian,zhangsoledad |
|
Build succeeded: |
yangby-cryptape
added
u:ckb2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestions for Review
The best way to review this PR is reviewing each commit independently.
Brief introduction for Commits
New hardfork Features
All following features can be found in RFC PRs.
feat(hardfork): in the "since epoch", the index should be less than length
Ref: CKB-RFCs PR 223: Ensure that index < length in input since field using epoch
feat(hardfork): use block timestamp of input cells as relative since start timestamp
Ref: CKB-RFCs PR 221: Use Block Timestamp as Start Timestamp in Since
[Reverted]
feat(hardfork): allow unknown block versions and transactions versionsRef: CKB-RFCs PR 230: Allow unknown tx & block versionfeat(hardfork): allow script multiple matches on identical data for type hash-type scripts
Ref: CKB-RFCs PR 222: Allow script multiple matches on identical code
feat(hardfork): reuse the uncles hash in the header as the extra hash
Ref: CKB-RFCs PR 224: Add a variable length field in the block header
[Reverted]
feat(hardfork): allow loading uncommitted cell data hashes from tx poolRef: CKB-RFCs PR 228: ckb2021: fix load_cell_data_hash syscallOther Important Commits
feat(hardfork): setup the components for hard fork features
refactor: let verifiers know the real environment that the transaction is in
Almost all features require this refactor commit.
refactor: remove useless parameter "with_data" because it always be true (tricky)
So I can change less APIs and less code to apply the feature: allow loading uncommitted cell data hashes from tx pool.
About Tests
Almost all features have detailed integration tests (or unit tests):
All commits can passed all integration tests and unit tests.