Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Miner RPC method submit_block supposed to be called directly #94

Closed
ashchan opened this issue Dec 15, 2018 · 1 comment
Closed

Is Miner RPC method submit_block supposed to be called directly #94

ashchan opened this issue Dec 15, 2018 · 1 comment
Assignees

Comments

@ashchan
Copy link
Contributor

ashchan commented Dec 15, 2018

Is submit_block supposed to be called by any SDK client?

The inline example with the RPC method implementation doesn't work due to the lack of required elements for header. (raw and seal respectively).

curl -d '{"id": 2, "jsonrpc": "2.0", "method":"submit_block","params": [{"header":{}, "uncles":[], "commit_transactions":[], "proposal_transactions":[]}]}' -H 'content-type:application/json' 'http://localhost:8114'

@doitian
Copy link
Member

doitian commented Dec 16, 2018

No, submit_block and get_blocktemplate are only for miner implemention.

@doitian doitian closed this as completed Dec 16, 2018
bors bot added a commit that referenced this issue Mar 18, 2019
338: chore(deps): bump secp256k1 from 0.12.0 to 0.12.2 r=zhangsoledad a=dependabot[bot]

Bumps [secp256k1](https://github.com/rust-bitcoin/rust-secp256k1) from 0.12.0 to 0.12.2.
<details>
<summary>Changelog</summary>

*Sourced from [secp256k1's changelog](https://github.com/rust-bitcoin/rust-secp256k1/blob/master/CHANGELOG.md).*

> # 0.12.2 - 2019-01-18
> 
> * Fuzzer bug fix
> 
> # 0.12.1 - 2019-01-15
> 
> * Minor bug fixes
> * Fixed `cc` crate version to maintain minimum compiler version without breakage
> * Removed `libc` dependency as it our uses have been subsumed into stdlib
</details>
<details>
<summary>Commits</summary>

- [`77619e8`](rust-bitcoin/rust-secp256k1@77619e8) Merge pull request [#95](https://github-redirect.dependabot.com/rust-bitcoin/rust-secp256k1/issues/95) from rust-bitcoin/2019-01-0.12.2
- [`432face`](rust-bitcoin/rust-secp256k1@432face) bump version to 0.12.2
- [`a54f9b7`](rust-bitcoin/rust-secp256k1@a54f9b7) Merge pull request [#94](https://github-redirect.dependabot.com/rust-bitcoin/rust-secp256k1/issues/94) from TheBlueMatt/master
- [`f90e9f3`](rust-bitcoin/rust-secp256k1@f90e9f3) Stop checking context flags for secp256k1_ecdh as its not required
- [`0466b5e`](rust-bitcoin/rust-secp256k1@0466b5e) Merge pull request [#93](https://github-redirect.dependabot.com/rust-bitcoin/rust-secp256k1/issues/93) from rust-bitcoin/2019-0.12.1
- [`dd8866c`](rust-bitcoin/rust-secp256k1@dd8866c) bump version to 0.12.1
- [`dee10b9`](rust-bitcoin/rust-secp256k1@dee10b9) Merge pull request [#89](https://github-redirect.dependabot.com/rust-bitcoin/rust-secp256k1/issues/89) from TheBlueMatt/master
- [`fba7dfb`](rust-bitcoin/rust-secp256k1@fba7dfb) Fix cargo warning output and wrong pointer width ([#88](https://github-redirect.dependabot.com/rust-bitcoin/rust-secp256k1/issues/88))
- [`a74cbb6`](rust-bitcoin/rust-secp256k1@a74cbb6) Sync fuzztarget combine with tweak_add since real functions do that
- [`4f44a0f`](rust-bitcoin/rust-secp256k1@4f44a0f) Merge pull request [#87](https://github-redirect.dependabot.com/rust-bitcoin/rust-secp256k1/issues/87) from tomaka/rm-libc
- Additional commits viewable in [compare view](rust-bitcoin/rust-secp256k1@0.12.0...0.12.2)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=secp256k1&package-manager=cargo&previous-version=0.12.0&new-version=0.12.2)](https://dependabot.com/compatibility-score.html?dependency-name=secp256k1&package-manager=cargo&previous-version=0.12.0&new-version=0.12.2)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

Co-authored-by: dependabot[bot] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants