refactor: use TransactionVec to persist tx pool

benches/benches/benchmarks/overall.rs

@@ -126,7 +126,7 @@ pub fn setup_chain(txs_size: usize) -> (Shared, ChainController) {
         .unwrap();
 
     let network = dummy_network(&shared);
-    pack.take_tx_pool_builder().start(network);
+    pack.take_tx_pool_builder().start(network).unwrap();
 
     let chain_service = ChainService::new(shared.clone(), pack.take_proposal_table());
     let chain_controller = chain_service.start(Some("ChainService"));

chain/src/tests/block_assembler.rs

@@ -45,7 +45,7 @@ fn start_chain(consensus: Option<Consensus>) -> (ChainController, Shared) {
         .unwrap();
 
     let network = dummy_network(&shared);
-    pack.take_tx_pool_builder().start(network);
+    pack.take_tx_pool_builder().start(network).unwrap();
 
     let chain_service = ChainService::new(shared.clone(), pack.take_proposal_table());
     let chain_controller = chain_service.start::<&str>(None);

chain/src/tests/util.rs

@@ -127,7 +127,7 @@ pub(crate) fn start_chain(consensus: Option<Consensus>) -> (ChainController, Sha
         .build()
         .unwrap();
     let network = dummy_network(&shared);
-    pack.take_tx_pool_builder().start(network);
+    pack.take_tx_pool_builder().start(network).unwrap();
 
     let chain_service = ChainService::new(shared.clone(), pack.take_proposal_table());
     let chain_controller = chain_service.start::<&str>(None);

ckb-bin/src/subcommand/replay.rs

@@ -19,7 +19,7 @@ pub fn replay(args: ReplayArgs, async_handle: Handle) -> Result<(), ExitCode> {
     )?;
     let (shared, _) = shared_builder
         .consensus(args.consensus.clone())
-        .tx_pool_config(args.config.tx_pool)
+        .tx_pool_config(args.config.tx_pool.clone())
         .build()?;
 
     if !args.tmp_target.is_dir() {

ckb-bin/src/subcommand/run.rs

@@ -53,7 +53,10 @@ pub fn run(args: RunArgs, version: Version, async_handle: Handle) -> Result<(),
     );
 
     let tx_pool_builder = pack.take_tx_pool_builder();
-    tx_pool_builder.start(network_controller);
+    tx_pool_builder.start(network_controller).map_err(|err| {
+        eprintln!("TxPool Error: {}", err);
+        ExitCode::Failure
+    })?;
 
     let exit_handler_clone = exit_handler.clone();
     ctrlc::set_handler(move || {
@@ -63,18 +66,10 @@ pub fn run(args: RunArgs, version: Version, async_handle: Handle) -> Result<(),
     exit_handler.wait_for_exit();
 
     info!("Finishing work, please wait...");
+    shared.tx_pool_controller().save_pool().map_err(|err| {
+        eprintln!("TxPool Error: {}", err);
+        ExitCode::Failure
+    })?;
     drop(rpc_server);
-    drop(network_controller);
-    shared
-        .tx_pool_controller()
-        .persist_tx_pool()
-        .map_err(|err| {
-            eprintln!("TxPool Error: {}", err);
-            ExitCode::Failure
-        })?
-        .map_err(|err| {
-            eprintln!("TxPool Error: {}", err);
-            ExitCode::Failure
-        })?;
     Ok(())
 }

rpc/src/test.rs

@@ -179,7 +179,8 @@ fn setup_rpc_test_suite(height: u64) -> RpcTestSuite {
     };
 
     pack.take_tx_pool_builder()
-        .start(network_controller.clone());
+        .start(network_controller.clone())
+        .unwrap();
 
     // Build chain, insert [1, height) blocks
     let mut parent = always_success_consensus().genesis_block;

sync/src/relayer/tests/helper.rs

@@ -153,7 +153,7 @@ pub(crate) fn build_chain(tip: BlockNumber) -> (Relayer, OutPoint) {
     };
 
     let network = dummy_network(&shared);
-    pack.take_tx_pool_builder().start(network);
+    pack.take_tx_pool_builder().start(network).unwrap();
 
     let chain_controller = {
         let chain_service = ChainService::new(shared.clone(), pack.take_proposal_table());

test/src/specs/tx_pool/pool_persisted.rs

@@ -50,12 +50,16 @@ impl Spec for PoolPersisted {
 
         let tx_pool_info_reloaded = node0.get_tip_tx_pool_info();
         info!("TxPool should be same as before");
-        assert_eq!(tx_pool_info_original, tx_pool_info_reloaded);
+        assert_eq!(
+            tx_pool_info_original.total_tx_size,
+            tx_pool_info_reloaded.total_tx_size
+        );
+        assert_eq!(
+            tx_pool_info_original.total_tx_cycles,
+            tx_pool_info_reloaded.total_tx_cycles
+        );
 
         info!("Check the specific values of TxPool state");
         node0.assert_tx_pool_size(txs_hash2.len() as u64, txs_hash1.len() as u64);
-        assert!(tx_pool_info_reloaded.total_tx_size.value() > 0);
-        assert!(tx_pool_info_reloaded.total_tx_cycles.value() > 0);
-        assert!(tx_pool_info_reloaded.last_txs_updated_at.value() > 0);
     }
 }