Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
3028: refactor(rpc): change 'connected_duration' duration unit to milliseconds r=chanhsu001 a=chanhsu001 <!-- Thank you for contributing to nervosnetwork/ckb! If you haven't already, please read [CONTRIBUTING](https://github.com/nervosnetwork/ckb/blob/develop/CONTRIBUTING.md) document. If you're unsure about anything, just ask; somebody should be along to answer within a day or two. PR Title Format: 1. module [, module2, module3]: what's changed 2. *: what's changed --> ### What problem does this PR solve? make duration unit consistent in `get_peers` RPC Problem Summary: ### What is changed and how it works? Proposal: in 'get_peer' RPC, connected_duration uses secs but last_ping_duration uses millis, we need to change connected_duration uses millis. What's Changed: ### Related changes - PR to update `owner/repo`: - Need to cherry-pick to the release branch ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - Unit test Side effects - rpc client should change 'connected_duration' duration unit from 'second' to 'millisecond' when `get_peers` RPC is used. ### Release note <!-- Choose from None, Title Only and Note. Bugfixes or new features need a release note. --> ```release-note **BREAKING RPC**. Change field `connected_duration` time unit from seconds to **milliseconds** in `get_peers` RPC to make time unit used consistently in `get_peers` , RPC clients are suggested to modify time quantity correspond with this change. ``` Co-authored-by: chanhsu001 <[email protected]>
- Loading branch information