Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support open transaction operation #37

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

feat: Support open transaction operation #37

wants to merge 30 commits into from

Conversation

liuck8080
Copy link
Contributor

Changes:

  • Support basic open transaction like build/sign/;
  • Add parameter of &dyn TransactionDependencyProvider to ScriptSigner::sign_tx, so it can read necessary data when produce message for sign.
  • Add a test example transfer_from_opentx.rs

Liu Chuankai added 24 commits November 21, 2022 10:58
feat: 🎸 Add functions to read transaction data and hash
09e5751 
1. Add functions to read transaction data;
2. Handle opentx input commands.
feat: 🎸 add function to assemble multiple opentx to a tx
c0514f1
test: 💍 Add example to test opentx build
d33a21f
feat: 🎸 Can sign PubkeyHash opentx transaction
e3b4138
test: 💍 Add command to add input/output for opentx
f5ee456
feat: 🎸 OpenTx sign PubkeyHash ready
5beb844
test: 💍 Fix opentx example by add sighash dep
0b16ce7
feat: 🎸 sign for openx ethereum/multisig
08f3f6b
test: 💍 example about opentx ethereum
a10a58d
feat: 🎸 Finish example about opentx/multisig
21c9a53
docs: ✏️ complete docs about opentx/multisig example
1f0f95e
feat: 🎸 can put multi opentxes into one open transaction
e81a357 
1. merge multi opentx into one opentx;
2. put build open out code into builder.
3. finish example about merge
fix: 🐛 fix compile problems after merge from master
3e0805d
docs: ✏️ Move the big docs from source file to another doc
3bb4ea3
style: 💄 make code more readable
348b8d9
test: 💍 Add tests about opentx simple hash transfer
2c7add3
test: 💍 Add test about opentx simple multisig transfer
a15938a
test: 💍 Tests with index opentx input to end a transaction
a3e869c
test: 💍 Add test about multisig opentx test case
a204551
test: 💍 Add test about open transaction buy udt
56cd5f2
fix: 🐛 fix compile error after rebase master branch
840f9d7
chore: 🤖 Add Err for not configure open transaction list
65c3c62
chore: 🤖 Remove unnecessary output and add comments
65750b8
fix: 🐛 Handle opentx scriptgroup for merge
0337564
EthanYuan
EthanYuan suggested changes Dec 7, 2022
View reviewed changes
src/unlock/opentx/hasher.rs Outdated Show resolved Hide resolved
src/unlock/opentx/hasher.rs Outdated Show resolved Hide resolved
src/unlock/opentx/hasher.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EthanYuan EthanYuan EthanYuan requested changes

@TheWaWaR TheWaWaR TheWaWaR left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liuck8080 @TheWaWaR @EthanYuan