feat: get more last headers in the first proof of a newly connected peer #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the following scenario:
LAST_N_BLOCKS
.L
is shutdown with last stateL
, and it connects to a peerP
whose tip isSo, the first proof that
L
received fromP
, will contains onlyIf$t$ is very small, and
P
changes to another fork chain, then the fork block will be hard to find.ckb-light-client/src/protocols/light_client/mod.rs
Lines 364 to 376 in 0a8c34a
As a result, it is easy to trigger "long fork detected".
Changes