Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should mark fetching status as timeout when disconnect #158

Closed
wants to merge 1 commit into from

Conversation

quake
Copy link
Member

@quake quake commented Nov 20, 2023

No description provided.

@yangby-cryptape
Copy link
Collaborator

I updated the test to reproduce this bug.

You can rebase the commit, and update the last 2 assert with your bugfix.

With your bugfix:

-     assert_eq!(peers.get_txs_to_fetch().len(), 0);
-     assert_eq!(peers.get_headers_to_fetch().len(), 0);
+     assert_eq!(peers.get_txs_to_fetch().len(), 1);
+     assert_eq!(peers.get_headers_to_fetch().len(), 1);

p.s. I tested in my laptop.

@quake quake closed this Nov 20, 2023
@quake quake deleted the quake/fix-disconnect-timeout branch November 22, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants