Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump deps and toolchain to new versions #152

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

yangby-cryptape
Copy link
Collaborator

@yangby-cryptape yangby-cryptape commented Sep 27, 2023

Commits

Why don't upgrade CKB-related crates to v0.111.0?

Depends on CKB-related crates with v0.111.0-rc8 is fine.
But depends on CKB-related crates with v0.111.0-rc9, the cargo test under Windows in GitHub Action will be failed; I tried --test-threads 1 and it failed too.

👉 Click for details.
  • Unit tests cause error STATUS_STACK_BUFFER_OVERRUN under Windows in GitHub Action (windows-2019).

  • Unit tests are slower 3 times under Ubuntu in GitHub Action (CKB 0.111.0, Rust 1.72.1, ubuntu-latest).

@yangby-cryptape yangby-cryptape force-pushed the chore/upgrade-deps branch 4 times, most recently from 65a05ba to ac8b3c9 Compare September 27, 2023 08:44
@yangby-cryptape yangby-cryptape changed the title chore(deps): bump all deps and toolchain to their latest version chore(deps): bump deps to latest and toolchain to 1.71.1 Sep 27, 2023
@yangby-cryptape yangby-cryptape changed the title chore(deps): bump deps to latest and toolchain to 1.71.1 chore(deps): bump deps and toolchain to latest versions Sep 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ae04578) 69.80% compared to head (83c3a6b) 69.92%.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #152      +/-   ##
===========================================
+ Coverage    69.80%   69.92%   +0.12%     
===========================================
  Files           25       25              
  Lines         6348     6375      +27     
===========================================
+ Hits          4431     4458      +27     
  Misses        1917     1917              
Flag Coverage Δ
unittests 69.92% <98.64%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/protocols/light_client/mod.rs 69.12% <ø> (ø)
src/protocols/light_client/peers.rs 61.22% <100.00%> (-0.06%) ⬇️
...s/light_client/components/send_last_state_proof.rs 93.21% <98.50%> (+0.14%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yangby-cryptape yangby-cryptape changed the title chore(deps): bump deps and toolchain to latest versions chore(deps): bump deps and toolchain to new versions Sep 27, 2023
@yangby-cryptape yangby-cryptape marked this pull request as ready for review September 27, 2023 15:50
@quake quake merged commit 5d33576 into nervosnetwork:develop Sep 28, 2023
6 checks passed
@yangby-cryptape yangby-cryptape deleted the chore/upgrade-deps branch September 28, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants