-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in IE setting xhr.timeout before xhr.open() in version 2.6.0 #874
Comments
Udofalcon
changed the title
Bug in IE setting xhr.timeout before xhr.open()
Bug in IE setting xhr.timeout before xhr.open() in version 2.6.0
Jun 24, 2020
Can you provide IE version? |
IE 11. Specifically 11.836.18362.0. |
Merged
jiawulin001
added a commit
to ygj6/angular-file-upload
that referenced
this issue
Jul 3, 2020
Merged
Thanks for open this issue |
I know this is almost not maintained, but could you also make this so that the fix would execute when source maps are in use (minified or not). Also it would be nice to have the version via npmjs.com. |
luumik
pushed a commit
to luumik/angular-file-upload
that referenced
this issue
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The latest 2.6.0 update introduced a bug with Internet Explorer where we're setting xhr.timeout before calling xhr.open(). Internet Explorer cannot handle setting those keys on the XHR object without the request being open.
We encountered this bug while trying to upload a file, but we were able to boil the issue down to just this section: https://github.com/nervgh/angular-file-upload/blob/master/src/services/FileUploader.js#L516-L525
Moving
xhr.timeout = item.timeout || 0;
afterxhr.open(item.method, item.url, true);
should resolve this issue.This same bug doesn't seem to be present in Firefox, Chrome, or Edge.
The text was updated successfully, but these errors were encountered: