Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make heading margin templated #90

Merged
merged 3 commits into from
Aug 9, 2020
Merged

make heading margin templated #90

merged 3 commits into from
Aug 9, 2020

Conversation

ktownsend-personal
Copy link
Contributor

added a template variable for the heading margin: --banner-card-heading-margin

I need this for my tablet wall panels so I can make the heading more compact and better proportion of margin to heading font size. Please merge soon :)

@ktownsend-personal
Copy link
Contributor Author

I didn't change anything that would affect the build...odd that it failed.

@ktownsend-personal
Copy link
Contributor Author

@nervetattoo I'm not familiar with your checks pipeline. Any idea why I got this error from your checks on my pull request?

Error: Cannot find module '@ava/babel-preset-stage-4' from '/home/runner/work/banner-card/banner-card'

@nervetattoo nervetattoo merged commit c9e16e0 into nervetattoo:master Aug 9, 2020
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants