Support Grafana via prom_ex
#1518
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshk
force-pushed
the
prom-ex-and-grafana-love
branch
from
0e877c8
to
9d4afc7
Compare
This fixes a bunch of `force_ssl` issues since this one endpoint can be http only, plus its easy not to expose it to the world
|
I like the idea of this a lot, do we know how to have prometheus scrape ECS tasks directly? Last time I had a chance to work with prometheus it didn't handle dynamic pods/tasks/containers well (at least with whatever set up the company had haha) |
|
Sorry, I'm not sure on the best way to solve the prometheus scape part of the equation. Fly.io makes it super super easy by providing you a prometheus out of the box. We have this up and running with NervesCloud, including the correct taging of apps, instances, and hosts. |
joshk
force-pushed
the
prom-ex-and-grafana-love
branch
from
270a8a6
to
2eb3082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Grafana has become more of the norm, and this is the start of supporting all the Grafanas
Both the Web and Devices Endpoints are monitored, which gives us some initial insight into whats going on within the app.
I've implemented the
/metricsroute via a newMetricsEndpoint, as this allows us to expose it on its own port which isn't exposed, without SSL, which Fly can monitor via its Prometheus service.I think these dashboards require a little more work until I'm happy with the data, and insight, they provide.