Configure tls_certificate_check for tls config in swoosh #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OTP 26 changed the error level of what we're seeing when trying to send email to SES via TLS. This additional configuration should let us communicate via TLS without issues. See gen-smtp/gen_smtp#328
jjcarstens
reviewed
Mar 25, 2024
| @@ -293,6 +293,7 @@ if config_env() == :prod do | |||
| password: System.fetch_env!("SMTP_PASSWORD"), | |||
| ssl: System.get_env("SMTP_SSL", "false") == "true", | |||
| tls: :always, | |||
| tls_options: :tls_certificate_check.options(System.fetch_env!("SMTP_SERVER")), | |||
There was a problem hiding this comment.
Will this affect if System.get_env("SMTP_SSL", "false") == "false"? As in if its disabled and we still include SSL options, will things blow up?
There was a problem hiding this comment.
We do have tls: :always right below ssl: false which I'm not sure what the difference is.
It seems like the difference is ssl: false won't immediately try to start ssl, vs using starttls since we have tls: :always That's my read of the docs though https://github.com/gen-smtp/gen_smtp?tab=readme-ov-file#options
jjcarstens
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTP 26 changed the error level of what we're seeing when trying to send email to SES via TLS. This additional configuration should let us communicate via TLS without issues.
See gen-smtp/gen_smtp#328