Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Set FTP client timeout value by connect options #45

Merged
merged 4 commits into from
May 8, 2020

Conversation

skumail
Copy link
Contributor

@skumail skumail commented May 5, 2020

I have encountered an issue where FTP connection was timeout after 30 seconds the default timeout value for the basic-ftp client.

I want to increase the timeout value, but didn't got any option in the qusly-core client.

So I decide to extend the qusly-core to use the basic-ftp native connection timeout implementation.
https://github.com/patrickjuchli/basic-ftp/blob/master/src/Client.ts

Set Timeout value in milliseconds, use 0 for no timeout. Optional, default is 30 seconds.

sample code to set timeout value by 1 minute.

const client = new Client(); client.connect(config, {timeout: 60000});

@codecov-io
Copy link

codecov-io commented May 5, 2020

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   81.81%   81.81%           
=======================================
  Files           8        8           
  Lines         165      165           
  Branches       26       26           
=======================================
  Hits          135      135           
  Misses         20       20           
  Partials       10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4344bc1...44e4dc9. Read the comment docs.

@xnerhu xnerhu self-requested a review May 8, 2020 08:01
@xnerhu xnerhu added the enhancement New feature or request label May 8, 2020
@xnerhu
Copy link
Member

xnerhu commented May 8, 2020

Thanks for your pr!

@xnerhu xnerhu merged commit c3dc987 into nersent:master May 8, 2020
@xnerhu
Copy link
Member

xnerhu commented May 8, 2020

Published in v2.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants