[enhancement] Set FTP client timeout value by connect options #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have encountered an issue where FTP connection was timeout after 30 seconds the default timeout value for the basic-ftp client.
I want to increase the timeout value, but didn't got any option in the qusly-core client.
So I decide to extend the qusly-core to use the basic-ftp native connection timeout implementation.
https://github.com/patrickjuchli/basic-ftp/blob/master/src/Client.ts
Set Timeout value in milliseconds, use 0 for no timeout. Optional, default is 30 seconds.
sample code to set timeout value by 1 minute.
const client = new Client(); client.connect(config, {timeout: 60000});