Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write camera path to output dir if saving to the data dir fails #3476

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Write camera path to output dir if saving to the data dir fails #3476

wants to merge 3 commits into from

Conversation

krahets
Copy link
Contributor

@krahets krahets commented Oct 14, 2024

If we load data from a folder without write permissions, the Generate Command button in the render panel will not respond.

A simple solution is to write it to the output directory if writing to the data folder fails.

image

kerrj
kerrj requested changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@kerrj kerrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! can you also add some sort of log statement informing users that the data dir is unwritable and that it instead wrote the path to this location?

@krahets
Copy link
Contributor Author

krahets commented Oct 16, 2024

Sure. Does this meet your expectations?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerrj kerrj kerrj requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krahets @kerrj