Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing installation of gsplat for linux #3266

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hardikdava
Copy link
Contributor

No description provided.

@brentyi
Copy link
Collaborator

brentyi commented Jul 1, 2024

Hm, is it necessary to install gsplat from source? Shouldn't it be installed automatically from pip install nerfstudio?

"gsplat==1.0.0",

@KevinXu02
Copy link
Contributor

I think might only Windows need to install it from source because the vc environments.

@hardikdava
Copy link
Contributor Author

@KevinXu02 @brentyi I am installing nerfsudio on ubuntu and if i install gsplat from pip then I am getting this error:

  File "/home/hd/Desktop/workspace/ns/.venv/lib/python3.10/site-packages/gsplat/cuda/_wrapper.py", line 12, in call_cuda
    return getattr(_C, name)(*args, **kwargs)
AttributeError: 'NoneType' object has no attribute 'fully_fused_projection_fwd'

@liruilong940607
Copy link
Contributor

liruilong940607 commented Jul 18, 2024

I need to investigate the failure building cases of gsplat on windows.. Adding it to my TODO list

@liruilong940607 liruilong940607 self-assigned this Jul 18, 2024
@SharkWipf
Copy link
Contributor

I just noticed this PR, my PR #3333 has some more background on gsplat on Windows (and is the polar opposite of this PR lol).

Manually adding gsplat on Linux should not be necessary and there's probably something else going on, the reason it was added to the Windows documentation has to do with Visual Studio being a pain.

Including manually installing gsplat in the documentation should be avoided if possible, as this will break on new Nerfstudio/Gsplat releases and the documentation will need to be updated each update.

@hardikdava
Copy link
Contributor Author

@SharkWipf if you already included this PR fixes then we can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants