-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added missing installation of gsplat for linux #3266
base: main
Are you sure you want to change the base?
Conversation
Hm, is it necessary to install Line 66 in 90cc4f1
|
I think might only Windows need to install it from source because the vc environments. |
@KevinXu02 @brentyi I am installing nerfsudio on ubuntu and if i install gsplat from pip then I am getting this error:
|
I need to investigate the failure building cases of gsplat on windows.. Adding it to my TODO list |
I just noticed this PR, my PR #3333 has some more background on gsplat on Windows (and is the polar opposite of this PR lol). Manually adding gsplat on Linux should not be necessary and there's probably something else going on, the reason it was added to the Windows documentation has to do with Visual Studio being a pain. Including manually installing gsplat in the documentation should be avoided if possible, as this will break on new Nerfstudio/Gsplat releases and the documentation will need to be updated each update. |
@SharkWipf if you already included this PR fixes then we can close this PR. |
No description provided.