Share gRPC channels again #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts part of commit 4a2fe0c and fixes the test instability in a better way as tipped off by @AmeliasCode in [this comment](hyperium/tonic#1751 (comment)) and specifically shared by @gwy15 in [this comment](tokio-rs/tokio#2374 (comment)). It seems the problem was that after the first test finished, the runtime that 'owned' the Mutex or channel was shut down, breaking it for all subsequent users. By changing our tests to all use a shared runtime, the channel isn't killed and can therefore work in subsequent tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts part of commit 4a2fe0c and fixes the test instability in a better way as tipped off by @AmeliasCode in this comment and specifically shared by @gwy15 in this comment.
It seems the problem was that after the first test finished, the runtime that 'owned' the Mutex or channel was shut down, breaking it for all subsequent users. By changing our tests to all use a shared runtime, the channel isn't killed and can therefore work in subsequent tests.