Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner for godoc and license #492

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Conversation

subh007
Copy link
Contributor

@subh007 subh007 commented Jan 20, 2024

Added banner for godoc and license in README.md .

Added banner for godoc in README.md .

Signed-off-by: subhash kumar singh <[email protected]>
Added banner for license in README.md .

Signed-off-by: subhash kumar singh <[email protected]>
Copy link
Contributor

nephio-prow bot commented Jan 20, 2024

Hi @subh007. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liamfallon
Copy link
Member

/ok-to-test

@subh007
Copy link
Contributor Author

subh007 commented Jan 24, 2024

/assign @s3wong @henderiw if we are okay to add these badges in our README.md please approve the request.

@liamfallon
Copy link
Member

/approve

@subh007
Copy link
Contributor Author

subh007 commented Feb 6, 2024

/assign @henderiw

@liamfallon
Copy link
Member

/lgtm

@henderiw
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

nephio-prow bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: henderiw, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Feb 28, 2024
@nephio-prow nephio-prow bot merged commit 93e3e08 into nephio-project:main Feb 28, 2024
4 of 5 checks passed
PrimalPimmy pushed a commit to 5GSEC/nephio that referenced this pull request Aug 2, 2024
Added banner for godoc and license in README.md .

---------

Signed-off-by: subhash kumar singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants