Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing outdated variable #150

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Removing outdated variable #150

merged 1 commit into from
Jul 2, 2024

Conversation

arora-sagar
Copy link
Contributor

  • Variable ANSIBLE_CMD_EXTRA_VAR_LIST does not work properly

@arora-sagar
Removing outdated variable
8c11e38 
- Variable ANSIBLE_CMD_EXTRA_VAR_LIST does not work properly
@nephio-prow nephio-prow bot requested review from henderiw and s3wong July 2, 2024 14:17
@netlify Netlify
Copy link

netlify bot commented Jul 2, 2024 •
edited
Loading

✅ Deploy Preview for nephio ready!

Name Link
🔨 Latest commit 8c11e38
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/66840c0a05ec850008d4b8af
😎 Deploy Preview https://deploy-preview-150--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

vjayaramrh
vjayaramrh approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@vjayaramrh vjayaramrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jul 2, 2024
liamfallon
liamfallon reviewed Jul 2, 2024
View reviewed changes
Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon, vjayaramrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jul 2, 2024
@nephio-prow nephio-prow bot merged commit 2eee5ee into nephio-project:main Jul 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamfallon liamfallon liamfallon left review comments

@vjayaramrh vjayaramrh vjayaramrh approved these changes

@CsatariGergely CsatariGergely Awaiting requested review from CsatariGergely

Assignees

@liamfallon liamfallon

@vjayaramrh vjayaramrh

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arora-sagar @liamfallon @vjayaramrh