Category feed v2 #544
Open
Category feed v2 #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added X last blog posts in context, so that templates can display posts instead of only the total number of blog posts written by the selected authors
Closed
yakky
requested changes
Apr 7, 2020
There was a problem hiding this comment.
@palmitoto thanks for the cleaned up version, apart from the two minor comments, could you haev a look at the tests failures and could you add a test for the category feed along the lines of the per-tag feed?
| author.count = count | ||
| # "the number of author articles to be displayed" | ||
| author.posts = qs[:self.latest_posts] |
| @@ -80,11 +80,29 @@ def item_author_url(self, item): | |||
| class TagFeed(LatestEntriesFeed): | |||
| feed_items_number = get_setting('FEED_TAGS_ITEMS') | |||
There was a problem hiding this comment.
as you are using directly the setting, you can also remove this attribute
yakky
force-pushed
the
develop
branch
2 times, most recently
from
36e5e25
to
5220d47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this is a merge request to add a rss category feed.
In addition to the default settings, the number of items to display can be passed by parameters.