review and refactor according to github security scans

Signed-off-by: neo <[email protected]>
neowu · Nov 8, 2024 · 8cd7188 · 8cd7188
1 parent b6e0a1b
commit 8cd7188
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 20 deletions.
diff --git a/core-ng/src/main/java/core/framework/http/EventSource.java b/core-ng/src/main/java/core/framework/http/EventSource.java
@@ -45,25 +45,7 @@ public void close() {
 
     @Override
     public Iterator<Event> iterator() {
-        return new Iterator<>() {
-            @Override
-            public boolean hasNext() {
-                if (nextEvent != null) return true;
-                nextEvent = parseResponse(body.source());
-                return nextEvent != null;
-            }
-
-            @Override
-            public Event next() {
-                if (nextEvent != null || hasNext()) {
-                    var event = nextEvent;
-                    nextEvent = null;
-                    return event;
-                } else {
-                    throw new NoSuchElementException();
-                }
-            }
-        };
+        return new EventIterator();
     }
 
     private Event parseResponse(BufferedSource source) {
@@ -103,4 +85,24 @@ private Event parseResponse(BufferedSource source) {
 
     public record Event(String id, String data) {
     }
+
+    private class EventIterator implements Iterator<Event> {
+        @Override
+        public boolean hasNext() {
+            if (nextEvent != null) return true;
+            nextEvent = parseResponse(body.source());
+            return nextEvent != null;
+        }
+
+        @Override
+        public Event next() {
+            if (nextEvent != null || hasNext()) {
+                var event = nextEvent;
+                nextEvent = null;
+                return event;
+            } else {
+                throw new NoSuchElementException();
+            }
+        }
+    }
 }
diff --git a/core-ng/src/main/java/core/framework/util/Files.java b/core-ng/src/main/java/core/framework/util/Files.java
@@ -36,7 +36,7 @@ public static byte[] bytes(Path file) {
         } catch (IOException e) {
             throw new UncheckedIOException(e);
         } finally {
-            LOGGER.debug("bytes, file={}, elapsed={}", file.toString(), watch.elapsed());
+            LOGGER.debug("bytes, file={}, elapsed={}", file, watch.elapsed());
         }
     }