test_buffer: don't depend on version-dependent default values of 'define' #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-slm
changed the title
…ine' `test_options` has an assertion that tests whether setting a local value modifies the global value, but tests it against a hardcoded constant. This constant changed in neovim/neovim@fcfe535 and neovim@82a2e14 fixes it by using the new constant instead, but this causes tests to fail against even the latest released version of neovim. To make this version-agnostic, save the old global value, and assert that the new value is equal after setting the local value. Signed-off-by: Michel Alexandre Salim <[email protected]>
michel-slm
force-pushed
the
fix-test_buffer
branch
from
81dfcf2
to
0734690
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_optionshas an assertion that tests whether setting a local value modifies the global value, but tests it against a hardcoded constant.This constant changed in neovim/neovim@fcfe535
and
82a2e14 fixes it by using the new constant instead, but this causes tests to fail against even the latest released version of neovim.
To make this version-agnostic, save the old global value, and assert that the new value is equal after setting the local value.