Change the data type of a Buffer so that it works correctly #471
Conversation
| @@ -3,7 +3,7 @@ | |||
| from pynvim.compat import IS_PYTHON3, check_async | |||
|
|
|||
|
|
|||
| __all__ = ('Buffer') | |||
| __all__ = ['Buffer'] | |||
There was a problem hiding this comment.
Alternatively, make it an actual tuple by adding the missing comma:
| __all__ = ['Buffer'] | |
| __all__ = ('Buffer',) |
Looks like this is needed in pynvim/api/{nvim,tabpage,window}.py, pynvim/msgpack_rpc/event_loop/init.py, and pynvim/plugin/host.py.
There was a problem hiding this comment.
This does technically work however according to the reference guide the data type of __all__ is explicitly supposed to be a list
There was a problem hiding this comment.
@farisachugthai
Ok. A link/ref would have been useful, but I believe you.. :)
Can you update the other places also, please?
Looks like this is needed in pynvim/api/{nvim,tabpage,window}.py, pynvim/msgpack_rpc/event_loop/init.py, and pynvim/plugin/host.py.
There was a problem hiding this comment.
Couldn't find it in the ref again but some googling got me this from the tutorial.
https://docs.python.org/3/tutorial/modules.html#importing-from-a-package
The import statement uses the following convention: if a package’s __init__.py code defines a list named __all__, it is taken to be the list of module names that should be imported when from package import * is encountered. It is up to the package author to keep this list up-to-date when a new version of the package is released.
Yeah sure I can do that. Is it okay if we merge this and I do the rest in a separate PR?
Doesn't correctly import Buffer.
__all__is incorrectly defined as a tuple and as a result it tries importing each individual letter instead of the actual class.In addition, the python reference explicitly defines that
__all__should be a list.