Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coveragerc: parallel=1 #421

Merged
merged 8 commits into from
Jan 10, 2020
Merged

coveragerc: parallel=1 #421

merged 8 commits into from
Jan 10, 2020

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jan 9, 2020

Fixes:

INTERNALERROR> coverage.misc.CoverageException: Couldn't use data file '…/.coverage': UNIQUE constraint failed: meta.key

Ref: #418 (comment)

@blueyed
coveragerc: parallel=1
2a4a195 
Fixes:

> INTERNALERROR> coverage.misc.CoverageException: Couldn't use data file '…/.coverage': UNIQUE constraint failed: meta.key

Ref: neovim#418 (comment)
@blueyed blueyed mentioned this pull request Jan 9, 2020
Merged
@blueyed
--cov-append for Travis only
4793be0
@blueyed
ci: Travis: use install
6933a94 
Fixes a warning/msg:

> Could not locate requirements.txt. Override the install: key in your
> .travis.yml to install dependencies.
@blueyed
Copy link
Contributor Author

blueyed commented Jan 10, 2020

Scrutinizer complains about missing coverage:

Code Coverage was not sent to Scrutinizer.
Make sure that you have set-up your external service correctly.
You can find more information on this in the documentation:

https://scrutinizer-ci.com/docs/tools/external-code-coverage/

I guess that's what ocular is meant to do? There's no error in logs currently, but needs investigation then.

@justinmk
Copy link
Member

Thanks for trying :)

This is better than having all the travis builds fail, so let's merge it?

@justinmk
Copy link
Member

justinmk commented Jan 10, 2020 •
edited
Loading

We could also remove scrutinizer, is it ever useful?

@blueyed
Copy link
Contributor Author

blueyed commented Jan 10, 2020

We could also remove scrutinizer, is it ever useful?

Ok with me. /cc @fwalch (via bfa672e)

I've checked that the number of runs matches our uploads / calls of ocular: https://github.com/neovim/python-client/blob/97ed85a8ca2deaa1689c0dd5b979a2d3ae72b716/.scrutinizer.yml#L131-L134.

@blueyed
Copy link
Contributor Author

blueyed commented Jan 10, 2020

Removed it.
Hopefully it stops being triggered once merged, otherwise somebody would need to disable it (https://scrutinizer-ci.com/g/neovim/pynvim/).

@justinmk justinmk merged commit 588b1f7 into neovim:master Jan 10, 2020
@blueyed blueyed deleted the cov-parallel branch January 11, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blueyed @justinmk