-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rplugin: conditionally enable nested notifications #262
Conversation
Instead of introducing "urgent" as a jargon, can we re-use the "deferred" vs "non-deferred" concept? |
@justinmk The only issue is that it makes |
This rule really gets in the way. It is IMO much lower-priority than good names, consistency, and pretty much everything else. |
In this case consistency/everything else is that rplugin infrastructure (with @tarruda:s original restriction, or the neovim/neovim#6544 reimplementation) do implement an modified actor model where each rplugin only will handle one top-level request or notification at a time. (the modification is that nested requests are ok, but they can only be invoked because the rplugin itself did something that requires the request to be handled, to avoid dead-lock). On the other hand nvim is best described as a state machine of user input, and "deferred" /"undeferred" ("async" should never have been used for this) refers to what input states this event can be processed in, not whether the event is "nested" or not. It is therefore a different distinction and I see no point to use the same terminology. "urgent" might not be optimal, but preferably it should be a word that positively describes how it deviates from the default (actor-like) model. Perhaps |
0e71c04
to
80c0145
Compare
786c581
to
9752bbc
Compare
Brings the client up-to-date with Nvim 0.2.1 Changes since 0.1.13: * a2e1169 Fix tests on windows (neovim#201) * 9a0e729 fix an indexing bug when setting lines in a Range object (neovim#270) * 4abd5d0 Documentation update (neovim#272) * a703b47 make sure logging always uses UTF-8 regardless of locale (neovim#276) * 68aa352 argument to allow nested notification handlers (neovim#262)
Brings the client up-to-date with Nvim 0.2.1 Changes since 0.1.13: * a2e1169 Fix tests on windows (neovim#201) * 9a0e729 Fix an indexing bug when setting lines in a Range object (neovim#270) * 4abd5d0 Documentation update (neovim#272) * a703b47 Make sure logging always uses UTF-8 regardless of locale (neovim#276) * 68aa352 Argument to allow nested notification handlers (neovim#262)
Brings the client up-to-date with Nvim 0.2.1 Changes since 0.1.13: * a2e1169 Fix tests on windows (neovim#201) * 9a0e729 Fix an indexing bug when setting lines in a Range object (neovim#270) * 4abd5d0 Documentation update (neovim#272) * a703b47 Make sure logging always uses UTF-8 regardless of locale (neovim#276) * 68aa352 Add argument to allow nested notification handlers (neovim#262)
for neovim/neovim#6544