Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach child handler loop. #241

Merged
merged 1 commit into from
Jan 8, 2017

Conversation

heliomeiralins
Copy link
Contributor

@heliomeiralins heliomeiralins commented Jan 7, 2017

Fix problems reported in #238 for Python3.6. ( In python3.5 I couldn't reproduce the error)
Tested with python versions: 2.7.13, 3.4.5, 3.5.2 and 3.6.0.

In python 3.4, and 3.5, we have this:

Exception ignored in: <bound method _UnixSelectorEventLoop.__del__ of <_UnixSelectorEventLoop running=False closed=True debug=False>>
Traceback (most recent call last):
  File "/home/meiralins/.pyenv/versions/3.4.5/lib/python3.4/asyncio/base_events.py", line 417, in __del__
  File "/home/meiralins/.pyenv/versions/3.4.5/lib/python3.4/asyncio/unix_events.py", line 58, in close
  File "/home/meiralins/.pyenv/versions/3.4.5/lib/python3.4/asyncio/unix_events.py", line 139, in remove_signal_handler
TypeError: signal handler must be signal.SIG_IGN, signal.SIG_DFL, or a callable object
Exception ignored in: Exception ignored in: Exception ignored in: %
Exception ignored in: <bound method BaseEventLoop.__del__ of <_UnixSelectorEventLoop running=False closed=True debug=False>>
Traceback (most recent call last):
  File "/home/meiralins/.pyenv/versions/3.5.2/lib/python3.5/asyncio/base_events.py", line 431, in __del__
  File "/home/meiralins/.pyenv/versions/3.5.2/lib/python3.5/asyncio/unix_events.py", line 58, in close
  File "/home/meiralins/.pyenv/versions/3.5.2/lib/python3.5/asyncio/unix_events.py", line 139, in remove_signal_handler
  File "/home/meiralins/.pyenv/versions/3.5.2/lib/python3.5/signal.py", line 47, in signal
TypeError: signal handler must be signal.SIG_IGN, signal.SIG_DFL, or a callable object

I'm not sure how to fix it yet.

@justinmk
Copy link
Member

justinmk commented Jan 7, 2017

The change seems reasonable, based on the error message in #238. I couldn't find any results on what change in asyncio made this necessary. It's somewhat surprising that it ever worked.

I'll merge this if there are no objections.

cc @bfredl @jamessan

@jamessan
Copy link
Member

jamessan commented Jan 8, 2017

I can confirm that fixed the problem I reported.

@justinmk justinmk merged commit 549f721 into neovim:master Jan 8, 2017
@heliomeiralins heliomeiralins mentioned this pull request Jan 12, 2017
@heliomeiralins heliomeiralins deleted the child-handler-fix branch October 11, 2017 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants