-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add php-language-server #653
Conversation
CONFIG.md
Outdated
|
||
To use `php-language-server`, you must define `cmd` when you setup the language server: | ||
```lua | ||
require'lspconfig'.sumneko_lua.setup { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be php_language_server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we use the official name in the docs. Substitute underscores is just a lua thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I'm not clear. It requires sumneko_lua
for php server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, it's a typo
skip-checks: true
@sunzoje did you try this? Does it work? |
I don't use php that much. Let me test and report back to you. |
|
Did you generate stubs like in the installation instructions?
|
I missed that part. I thought that part is optional. |
I'm not able to generate stubs; getting following error:
This issue is documented in felixfbecker/php-language-server#795. |
It seems that to use that php LSP it is required a local patched version or that someone does a fork. Very sad as it is seems that is abandoned. At the same time is the most used and famous language server for php -.-' |
Request from reddit, I can't test because I can't get composer to install php language server.