Update util.rootpath to search all patterns per path => Fixes kotlin-ls root dir on multi-project builds #3321
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR converted to Draft to follow contributing guidelines. |
paulodiovani
force-pushed
the
bugfix/find-closest-kotlin-root
branch
from
181dd66
to
8de95b1
Compare
util.root_path used to search each pattern on all parent directories, with this change it will look for all patterns on each parent dir, thus finding closest matchers first.
paulodiovani
force-pushed
the
bugfix/find-closest-kotlin-root
branch
from
8de95b1
to
014b33f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
util.root_pathloops first from a list of patterns and then searches for matching files on parent folders.See https://github.com/paulodiovani/nvim-lspconfig/blob/a9bc587e9ae0cbcb3e90a2e9342f86b3b78c4408/lua/lspconfig/util.lua#L279-L281
This makes the pattern list have precedence over paths, often matching patterns on parent folders before closest ones.
The issue happens with Gradle Multi Project Builds using Kotlin LS as described at fwcd/kotlin-language-server#559.
This PR swaps the loops, making sure all patterns are searched on each dir before moving up the ladder.
utilpackage, this may affect other LSP Servers.If it breaks any of them I can find a solution for Kotlin LS alone.