feat: ruby_lsp works inside eruby files

[adam12]

Since 0.17.5, Ruby LSP has supported running inside ERB files.

[defsdoor]

What is your experience with ruby-lsp on .erb files ? I'm running 0.17.12 and if I coerce nvim-lspconfig (via lazyvim) to use ruby-lsp for .erb (eruby) all it adds is errors on all <% - as if its not determining the file as Document::LanguageId::ERB

[vinistock]

@defsdoor please check this issue Shopify/ruby-lsp#2282. ERB support was added in v0.17.13, but if you have other gems constraining versions of rbs, prism or sorbet-runtime in your application, upgrading will fail and you will be unable to get the version of the language server that supports ERB.

[adam12]

What is your experience with ruby-lsp on .erb files ? I'm running 0.17.12 and if I coerce nvim-lspconfig (via lazyvim) to use ruby-lsp for .erb (eruby) all it adds is errors on all <% - as if its not determining the file as Document::LanguageId::ERB

I was able to use it without errors or warnings before submitting this PR, but we've noticed over in the ruby-lsp repo that there are similar errors which you are seeing.

I see those errors now locally, but I had updated a few things after patching lspconfig (as one does when they are procrastinating).

[defsdoor]

Odd thing is that after poking things a bit it's now working fine for me on 0.17.12..... And without this patch.

Updated nvim-lspconfig which now includes this patch and still working.

[elken]

Following up from Shopify/ruby-lsp#2432 (comment) that it seems this PR should be reverted as it's proven quite a disruptive change that Neovim doesn't seem to be ready to handle yet.

(see my comment after, and please correct me if I'm wrong)

EDIT: this will be the case as of #3269