Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not process if commands[i] is func type #3200

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

blmarket
Copy link
Contributor

@blmarket blmarket commented Jun 9, 2024

Context: #3087 (comment)

I want to set commands argument in vim.lsp.ClientConfig which has table<string, fun> type, which is not conforming to lspconfig's own commands type. lspconfig has to skip them for user command registrations.

@glepnir
Copy link
Member

glepnir commented Jun 10, 2024

lint fix.

To pass it as-is to the vim.lsp.start_client argument
@blmarket blmarket changed the title Do not touch if commands[i] is function feat: do not process if commands[i] is func type Jun 11, 2024
@blmarket
Copy link
Contributor Author

Hello, can I get review again?

@glepnir glepnir merged commit 53a3c64 into neovim:master Jul 1, 2024
9 checks passed
elijah-potter pushed a commit to elijah-potter/nvim-lspconfig that referenced this pull request Jul 25, 2024
To pass it as-is to the vim.lsp.start_client argument
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants