Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dprint lsp #2982

Merged
merged 1 commit into from
Jan 31, 2024
Merged

feat: add dprint lsp #2982

merged 1 commit into from
Jan 31, 2024

Conversation

WhoIsSethDaniel
Copy link
Contributor

No description provided.

@WhoIsSethDaniel
Copy link
Contributor Author

WhoIsSethDaniel commented Jan 23, 2024

the dprint lsp supports all filetypes that dprint supports. But these are all determined via configuration. So it's up to the user to decide what filetypes to use dprint for. So I left the filetypes empty.

return {
default_config = {
cmd = { 'dprint', 'lsp' },
filetypes = {},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be remove

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@WhoIsSethDaniel WhoIsSethDaniel Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think null-ls should be used as a source of truth. dprint, when installed, doesn't come with any support for anything. You can later configure it for one or many different languages.

If placing all these filetypes in the filetypes is what it takes to add this to nvim-lspconfig I'll do it. I don't think having the filetypes be too expansive is that bad. And that's what I have now done.

@glepnir glepnir merged commit 7fd5d1d into neovim:master Jan 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants