Improve LTeX support #2979
Merged
Improve LTeX support #2979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately language code `sweave` will not be understood by LTeX and `rsweave` must be used, as can be seen in the source code here: https://github.com/valentjn/ltex-ls/blob/16.0.0/src/main/kotlin/org/bsplines/ltexls/parsing/CodeFragmentizer.kt#L61 and here: https://github.com/valentjn/ltex-ls/blob/16.0.0/src/main/kotlin/org/bsplines/ltexls/settings/Settings.kt#L185 LTeX will fall back to plaintext, but this will emit a warning and provide slightly worse suggestions.
This mapping does not do anything, the `get_language_id` function will just return `xhtml` by default.
LTeX will only understand `plaintext`: https://github.com/valentjn/ltex-ls/blob/16.0.0/src/main/kotlin/org/bsplines/ltexls/parsing/CodeFragmentizer.kt#L70 though it will fall back to plain text when provided `text` as mapping, but will output a warning when doing so. Note that we do not enable the `text` filetype by default, as LTeX itself does not do so. However, this filetype will not be useable without this mapping anyway, so doing this makes using enabling this manually slightly easier.
LTeX is launched whenever the filetype is on the preset list, but will then verify the language ID against its list and will refuse to run if the language ID is not on the list. The default can be seen in https://github.com/valentjn/ltex-ls/blob/16.0.0/src/main/kotlin/org/bsplines/ltexls/settings/Settings.kt#L175 and somewhat matches the supported markup languages list. The issue resolved by this commit comes from the fact that LTeX will accept several aliases for each language, for instance it will handle `gitcommit` and `git-commit` the same way. However, only `git-commit` appears on the default enabled list. Since there is no `gitcommit -> git-commit` mapping in `language_id_mapping`, LTeX will ignore `gitcommit`. This could also be solved by adding this mapping, however setting a default value of `ltex.enabled` has smaller change of breaking existing configuration. Same situation happens for `xhtml`.
ConTeXt was requested in neovim#2663. LTeX is documented to enable it by default, but this is not consistent with the default in the code: https://github.com/valentjn/ltex-ls/blob/16.0.0/src/main/kotlin/org/bsplines/ltexls/settings/Settings.kt#L175 Regardless of this we will enable it by ourselves anyway. We also enable HTML and XHTML as there already has been an attempt to enable them previously, as there has been a mapping for `xhtml` in the `language_id_mapping` array. HTML support is enabled in LTeX by default anyway.
|
Lint failed due to URLs in some commit messages. Should I remove them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds ConTeXt support as requested in #2663. It also makes LTeX work correctly in rnoweb, HTML, XHTML and git commit messages, as well as in plaintext (though this is not enabled by default).