fix: typos root directory indicator #2935
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
.git
as root pattern. Doing so fixes some issues associated with nested workspaces / repos with multipletypos.toml
configuration file, that are further elaborated here: tekumara/typos-lsp#23 Long story short, having.git
as root indicator can in some situations lead to not detectingtypos.toml
configuration files.typos-lsp
runs fine in single-file-mode when no root pattern can be found. In fact, as far as I can tell, picking up a configuration file is the only reason thetypos-lsp
actually needs a root pattern for, otherwise single file mode works fine, probably since the LSP is only a wrapper around thetypos
cli. Thus, there should be no downside to removing.git
as root pattern, and the only consequence would be to fix issues with multipletypos.toml
files.