Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos root directory indicator #2935

Merged
merged 1 commit into from
Dec 19, 2023
Merged

fix: typos root directory indicator #2935

merged 1 commit into from
Dec 19, 2023

Conversation

chrisgrieser
Copy link
Contributor

@chrisgrieser chrisgrieser commented Dec 18, 2023

This PR removes .git as root pattern. Doing so fixes some issues associated with nested workspaces / repos with multiple typos.toml configuration file, that are further elaborated here: tekumara/typos-lsp#23 Long story short, having .git as root indicator can in some situations lead to not detecting typos.toml configuration files.

typos-lsp runs fine in single-file-mode when no root pattern can be found. In fact, as far as I can tell, picking up a configuration file is the only reason the typos-lsp actually needs a root pattern for, otherwise single file mode works fine, probably since the LSP is only a wrapper around the typos cli. Thus, there should be no downside to removing .git as root pattern, and the only consequence would be to fix issues with multiple typos.toml files.

@glepnir glepnir merged commit da40006 into neovim:master Dec 19, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants