fix(zls): include build.zig in root dir search
#2933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not change |
lawrence-laz
force-pushed
the
fix-zls-look-for-build-zig
branch
from
6e200c6
to
2f2ec21
Compare
File `build.zig` by convention sits at the root dir and thus can be used to correctly identify the root directory. This is particularly useful if `zls` has `enable_build_on_save` set to `true`, since then the language server uses workspace path (root_dir) to execute `zig build` command, output of which is then used to publish diagnostic errors. Without `build.zig` root directory can incorrectly be deduced some layers too high at the root of the git repo. In such case `enable_build_on_save` silently fails and does not report build error diagnostics.
lawrence-laz
force-pushed
the
fix-zls-look-for-build-zig
branch
from
2f2ec21
to
cc4fdfe
Compare
lawrence-laz
changed the title
build.zig in root dir searchbuild.zig in root dir search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File
build.zigby convention sits at the root dir and thus can be used to correctly identify the root directory.This is particularly useful if
zlshasenable_build_on_saveset totrue, since then the language server uses workspace path (root_dir) to executezig buildcommand, output of which is then used to publish diagnostic errors.Without
build.zigroot directory can incorrectly be deduced some layers too high at the root of the git repo. In such caseenable_build_on_savesilently fails and does not report build error diagnostics.