Allow empty section string for configuration request

[ms]

microsoft/vscode-eslint requests configuration with a section of ''.
This change returns the expected settings in that case.

https://github.com/microsoft/vscode-eslint/blob/be30e933c56ea6e8e579808d5f7c7b205c8e16cc/server/src/eslintServer.ts#L668

[h-michael]

I think that if item.section doesn't include ".", VSCode does not return the whole config.settings but return config built by URI resource.

https://github.com/microsoft/vscode-languageserver-node/blob/082631da44d6799358602a4abebadbf4fc47859b/client/src/configuration.ts#L49-L51

[ms]

So would you recommend leaving it as is? I'm struggling to find the code corresponding to workspace.getConfiguration() to see what it does (and whether the object it returns handles .get in any special way)

[h-michael]

I'll check VSCode behavior.

[h-michael]

microsoft/language-server-protocol#972

[h-michael]

@ms Sorry I haven't been able to start addressing this.
Once I have resolved some of the issues I will tackle this issue again.

[ms]

No rush, Iike you point out in microsoft/language-server-protocol#972 it's not really clear what the client should do, and either way it's easy enough to add an empty string key for now.

[h-michael]

@ms I read some clients implements and spec.
I think we can merge this changes.
Could you reopen this?

[ms]

Reopened, feel free to merge as is or push changes if you'd like

[h-michael]

@ms ty : )