Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msgpack: add more testcases #91

Merged
merged 47 commits into from
Jan 6, 2021
Merged

msgpack: add more testcases #91

merged 47 commits into from
Jan 6, 2021

Conversation

zchee
Copy link
Member

@zchee zchee commented Jan 6, 2021

Add more testcases to msgpack and msgpack/rpc packages.

@zchee zchee self-assigned this Jan 6, 2021
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #91 (7556bc0) into master (726b60e) will increase coverage by 2.2%.
The diff coverage is 60.2%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #91     +/-   ##
========================================
+ Coverage    60.6%   62.8%   +2.2%     
========================================
  Files          12      13      +1     
  Lines        2079    2080      +1     
========================================
+ Hits         1260    1307     +47     
+ Misses        684     636     -48     
- Partials      135     137      +2     
Flag Coverage Δ
linux-1.13 62.8% <60.2%> (+2.2%) ⬆️
linux-1.14 62.8% <60.2%> (+2.2%) ⬆️
linux-1.15 62.8% <60.2%> (+2.2%) ⬆️
linux-1.16 62.8% <60.2%> (+2.2%) ⬆️
macos-1.13 62.8% <60.2%> (+2.2%) ⬆️
macos-1.14 62.8% <60.2%> (+2.2%) ⬆️
macos-1.15 62.8% <60.2%> (+2.2%) ⬆️
macos-1.16 62.8% <60.2%> (+2.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
msgpack/field.go 71.0% <0.0%> (ø)
msgpack/unpack.go 90.6% <0.0%> (+4.6%) ⬆️
msgpack/decode.go 75.9% <50.0%> (+11.5%) ⬆️
msgpack/rpc/rpc.go 58.0% <57.8%> (ø)
msgpack/msgpack.go 66.6% <66.6%> (ø)
msgpack/pack.go 87.5% <66.6%> (ø)
msgpack/encode.go 76.7% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 726b60e...7556bc0. Read the comment docs.

@zchee zchee merged commit 7556bc0 into master Jan 6, 2021
@zchee zchee deleted the msgpack-tests branch January 6, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant