Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get virtual text fix extmark #78

Merged
merged 7 commits into from
Nov 8, 2020

Conversation

zchee
Copy link
Member

@zchee zchee commented Oct 19, 2020

Remove get_virtual_text api and fix extmark raleted args

@zchee zchee self-assigned this Oct 19, 2020
@zchee zchee requested a review from h-michael October 19, 2020 22:24
@h-michael
Copy link

@zchee It seems that we should update codecov GHA. ref: #79

@zchee
Copy link
Member Author

zchee commented Nov 6, 2020

@h-michael sorry for late.
Your PR might be works codecov! but seems to atill draft, Can I just copy code to this PRfrom your PR, and close #79?

@zchee zchee force-pushed the remove-get_virtual_text-fix_extmark branch 2 times, most recently from 1b5b01e to c403d97 Compare November 7, 2020 19:50
@zchee zchee force-pushed the remove-get_virtual_text-fix_extmark branch from c403d97 to 8ef0007 Compare November 7, 2020 19:51
@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #78 (7a87a37) into master (acbae1a) will increase coverage by 1.3%.
The diff coverage is 50.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #78     +/-   ##
========================================
+ Coverage    56.1%   57.4%   +1.3%     
========================================
  Files          11      11             
  Lines        2636    2124    -512     
========================================
- Hits         1479    1221    -258     
+ Misses       1021     769    -252     
+ Partials      136     134      -2     
Impacted Files Coverage Δ
nvim/apiimp.go 24.1% <50.0%> (+2.1%) ⬆️
nvim/plugin/plugin.go 31.5% <0.0%> (-3.9%) ⬇️
msgpack/encode.go 76.7% <0.0%> (-3.6%) ⬇️
msgpack/rpc/endpoint.go 58.0% <0.0%> (-3.2%) ⬇️
msgpack/decode.go 63.7% <0.0%> (-3.1%) ⬇️
msgpack/unpack.go 82.9% <0.0%> (-2.3%) ⬇️
msgpack/common.go 70.7% <0.0%> (-2.0%) ⬇️
nvim/plugin/main.go 31.1% <0.0%> (-0.2%) ⬇️
msgpack/pack.go 87.5% <0.0%> (-0.1%) ⬇️
nvim/nvim.go 68.8% <0.0%> (+0.1%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acbae1a...7a87a37. Read the comment docs.

@zchee
Copy link
Member Author

zchee commented Nov 7, 2020

@h-michael PTAL.

@zchee zchee merged commit 7a87a37 into master Nov 8, 2020
@zchee zchee deleted the remove-get_virtual_text-fix_extmark branch November 8, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants