Coverage increase executor #22
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommysr
force-pushed
the
coverage-increase-executor
branch
from
1c4baf2 to
bce8056
Compare
tejks
reviewed
Jun 14, 2024
| executor.commitBatches(genesisStoredBatchInfo, wrongNewCommitBatchInfoArray); | ||
| } | ||
|
|
||
| function hashSlice(bytes memory data, uint256 start, uint256 end) internal pure returns (bytes32) { |
There was a problem hiding this comment.
Maybe move it up to the top of the file.
There was a problem hiding this comment.
Or to the ExecutorTest contract
tejks
reviewed
Jun 14, 2024
| @@ -256,61 +398,199 @@ contract CommittingTest is ExecutorTest { | |||
| executor.commitBatches(genesisStoredBatchInfo, wrongNewCommitBatchInfoArray); | |||
| } | |||
|
|
|||
| function _getCommitInfoWithLogs(bytes[] memory logs) internal returns (IExecutor.CommitBatchInfo[] memory) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Increased coverage in Executor test
Why ❔
Checklist