Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridgehub test coverage increase + change in bridgehub! #15

Closed
wants to merge 6 commits into from

Conversation

tommysr
Copy link
Collaborator

@tommysr tommysr commented May 23, 2024

What ❔

Increased coverage in bridgehub unit tests, add some cases for two bridges deposit.
Changed order of assert in Bridgehub contract.

Why ❔

Previous tests had low coverage on branches, asserts and types of deposits, theirs permutations.

Checklist

  • overall tests to increase coverage
  • deposit eth using second bridge to non eth base chain
  • deposit nonbase token using second bridge to some erc20 base chain

@tommysr tommysr changed the title Bridgehub test coverage increase Bridgehub test coverage increase + change in bridgehub! May 24, 2024
@tommysr tommysr requested a review from tejks May 24, 2024 11:01
@tommysr tommysr marked this pull request as ready for review May 24, 2024 11:04
@tommysr
Copy link
Collaborator Author

tommysr commented May 27, 2024

matter-labs#494

opened do main repo, closing

@tommysr tommysr closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant