-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: add recursive directory creation in setup db command #62
BUGFIX: add recursive directory creation in setup db command #62
Conversation
@kitsunet not sure about the directory handling, something rings a bell with symlink resolution etc. Is this an issue here or can we just assume this works everywhere? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi thanks for this fix, looks good by reading. FYI at first there was no support for context handling at all and it would just dump it into the root. Simple context like TEsting or Dev seems to work already but not nested.
Also (cause im stupid) the neos-neos setup thing has also to be adjusted: https://github.com/neos/neos-setup/blob/7af338ea33d2ada0289c91c49844bbaf91ffdbb6/Classes/Command/SetupCommandController.php#L95
Created also a pr for the neos.neos thing neos/neos-setup#17 |
Hey, I am really not sure were to address this, I hope it is ok here: In the Forum discuss.neos.io I get currently a Http 500 when trying to sign up, so I can't ask there. Or is there another place to address this issue? |
Hi @jonaphil |
Thanks a lot! |
Current behavior:
If an custom flow context like
Development/Docker
is configured before configuring the database, then the db config file can not be written.Expected behavior:
Need subcontext folders are create and the db conifg file ist written correctly.