Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: add recursive directory creation in setup db command #62

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

andrehoffmann30
Copy link

@andrehoffmann30 andrehoffmann30 commented Jun 1, 2024

Current behavior:
If an custom flow context like Development/Docker is configured before configuring the database, then the db config file can not be written.

Expected behavior:
Need subcontext folders are create and the db conifg file ist written correctly.

@nezaniel nezaniel requested review from kitsunet and mhsdesign June 1, 2024 09:49
@nezaniel
Copy link
Member

nezaniel commented Jun 1, 2024

@kitsunet not sure about the directory handling, something rings a bell with symlink resolution etc. Is this an issue here or can we just assume this works everywhere?

Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thanks for this fix, looks good by reading. FYI at first there was no support for context handling at all and it would just dump it into the root. Simple context like TEsting or Dev seems to work already but not nested.

Also (cause im stupid) the neos-neos setup thing has also to be adjusted: https://github.com/neos/neos-setup/blob/7af338ea33d2ada0289c91c49844bbaf91ffdbb6/Classes/Command/SetupCommandController.php#L95

@pKallert pKallert self-requested a review June 27, 2024 14:20
@mhsdesign mhsdesign changed the base branch from main to 6.0 July 27, 2024 15:41
mhsdesign added a commit to neos/neos-setup that referenced this pull request Jul 27, 2024
@mhsdesign mhsdesign merged commit 3a29d02 into neos:6.0 Jul 27, 2024
1 check passed
@mhsdesign
Copy link
Member

Created also a pr for the neos.neos thing neos/neos-setup#17

@jonaphil
Copy link

jonaphil commented Oct 11, 2024

Hey,

I am really not sure were to address this, I hope it is ok here:
Is it possible to merge this bugfix into main? I had the same issue, got a little confused, tried to fix the docs and then found out it was a bug and got already fixed. But when I installed Neos in the recommended way using docker, the bug got shipped as well.

In the Forum discuss.neos.io I get currently a Http 500 when trying to sign up, so I can't ask there. Or is there another place to address this issue?

@pKallert
Copy link

Hi @jonaphil
@mhsdesign will take care of releasing/versioning here 👍 .
If you have questions or issues you can ask in our Slack: https://slack.neos.io/ - you should get quick responses there.
We are also fixing the signup for the forum, thanks for notifying us!

@mhsdesign
Copy link
Member

@jonaphil
Copy link

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants