TASK: Remove duplicate index

[dlubitz]

This migration removes the index sourceuripathhash as it is a dpulicate of the index flow_identity_neos_redirecthandler_databasestorage_domain_60892.

This is not necessary and leads to unwanted change requests in database migration generation (#9).

See also:

• Doctrine-Migration INCOHERENCES on fresh Neos setup of versions 5.x || 7.x || 8.x neos-development-collection#3118
• Fresh Neos installation with missing migrations neos-development-collection#2475

[kdambekalns]

I am very sure the "properly named index" should be kept. No clue (yet) where the other comes from!

[dlubitz]

I am very sure the "properly named index" should be kept. No clue (yet) where the other comes from!

Ok, but the other one has a additional unique constaint.

[kdambekalns]

This is where the index (should) come from

redirecthandler-databasestorage/Classes/Domain/Model/Redirect.php

Lines 28 to 33 in 4d17a80

	* @ORM\Table(
	* indexes={
	* @ORM\Index(name="sourceuripathhash",columns={"sourceuripathhash","host"}),
	* @ORM\Index(name="targeturipathhash",columns={"targeturipathhash","host"})
	* }
	* )

[kdambekalns]

The migration only the the named one…

https://github.com/neos/redirecthandler-databasestorage/blob/4d17a80ebbbb6997537374c1f9fe5d846d204226/Migrations/Mysql/Version20160418100005.php

Do you know where the index comes from? Is it implicitly created?

[dlubitz]

It seems to come from the migration only:
https://github.com/neos/redirecthandler-databasestorage/blob/master/Migrations/Mysql/Version20160418100005.php#L20

[kdambekalns]

Ah, so this is the cause:

redirecthandler-databasestorage/Classes/Domain/Model/Redirect.php

Line 68 in 4d17a80

* @Flow\Identity

[dlubitz]

Yes, seems so. Removig it creates a migration for removing the flow_identity_neos_redirecthandler_databasestorage_domain_60892 index.

[kdambekalns]

Ok, if you fix the platform comparison and remove the no longer needed index definition from Redirect, thou shall pass. 🧙‍♂️

[dlubitz]

Question is, if we can remove the unique constraint too? Or if it makes to move it to the other index?

[kdambekalns]

Question is, if we can remove the unique constraint too? Or if it makes to move it to the other index?

No, that one is built from @Flow\Identity and must stay. Drop the "duplicate named index" (as it is now) but remove it's definition from the model class, too.

[kdambekalns]

👀 by 📚

[kdambekalns]

Almost missed it: please do this for PostgreSQL, too!

[dlubitz]

Postgres migration is also added.

[kdambekalns]

👀 by 📚