-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Storybook integration #153
Conversation
There are some essential documentation features missing for Storybook, but it seems these guys plan to improve on that: storybookjs/storybook#166 (comment) |
I have created storybooks for all of our components. |
/cc @Inkdpixels please have a look! |
Looks pretty solid by reading! :) 👍 |
@Inkdpixels do you know perhaps why the test is failing? I couldn't have touched anything related to it... |
I will take a look at it this evening :) |
Hey @dimaip - I checked out your PR locally and I can indeed reproduce this error we are getting on CI. Until tomorrow evening I don't have much time to look into it, but I've found a storybook related issue of some guy which has the same error message, I think that's a good path we can follow. I you don't mind waiting, I will try to fix it tomorrow evening :) |
Hey @dimaip - I've found the location of the error. Basically the problem lies in the I've tested this locally, and it works.Could you either commit this, or give me access to your fork? Thanks buddy :) |
…ile creating the test bundle
@Inkdpixels thanks a lot for helping me out on this! Granted you access. I myself will be able to fix it on Monday, as well as document it. |
yay, done 💯 |
Hey @dimaip - I will merge this if you dont mind, since the only task left seems to be documentation and I also need to work on the previuosly changed |
Storybook allows running each UI component in isolation from the rest of UI. It even allows developing UI components without even setting up Neos installation itself!
We can also integrate http://storybooks.io/ when it's launched, so we'd be able to have an online reference and reviewing of UI code, without needing to test the pull request locally.