BUGFIX: Fusion avoid error on cache invalidation while developing #4838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
kdambekalns
reviewed
Jan 16, 2024
Replaces neos#4509 Resolves neos#4415 After deleting a fusion file like `BrandLogo.fusion` one will face the error after booting flow and thus triggering the file monitor and its listeners: (even like a simple `flow help`) ``` Couldn't resolve realpath for: '/absolutePath/Code/core/Neos.NeosIo/Packages/Sites/Neos.NeosIo/Resources/Private/Fusion/Content/BrandLogo/BrandLogo.fusion' ``` This is caused as `realpath` returns false if the file was deleted, and we were to eager validating this. But as flows file monitor already returns absolute paths we can skip the realpath calculation here and move it to the `ParserCache::cacheForFusionFile`. Initially the call to `realpath` was made in a single place to avoid making to many assumptions about the form flow returned file paths.
mhsdesign
force-pushed
the
bugfix/4415-fusion-error-on-dev-cache-invalidation-attempt-2
branch
from
c675950 to
5377b86
Compare
kitsunet
approved these changes
Jan 16, 2024
6 tasks
mhsdesign
deleted the
bugfix/4415-fusion-error-on-dev-cache-invalidation-attempt-2
branch
|
The thesis
was wrong. There will be symlinks instead of actual files which causes this regression: |
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #4509
Resolves #4415
After deleting a fusion file like
BrandLogo.fusionone will face the error after booting flow and thus triggering the file monitor and its listeners: (even like a simpleflow help)This is caused as
realpathreturns false if the file was deleted, and we were to eager validating this. But as flows file monitor already returns absolute paths we can skip the realpath calculation here and move it to theParserCache::cacheForFusionFile. Initially the call torealpathwas made in a single place to avoid making to many assumptions about the form flow returned file paths.Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions