Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Followup nodeTypes:show with --path to primitive value #4837

Merged
merged 1 commit into from
Feb 6, 2024
Merged

BUGFIX: Followup nodeTypes:show with --path to primitive value #4837

merged 1 commit into from
Feb 6, 2024

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Jan 16, 2024 •
edited by jonnitto
Loading

Related: #4619

Primitive values cannot be shown currently:

flow nodetypes:show Neos.Neos:Document --path properties.title.ui.label
Neos\ContentRepository\Command\NodeTypesCommandController_Original::truncateArrayAtLevel(): Argument #1 ($array) must be of type array, string given

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign
BUGFIX: Followup nodeTypes:show with --path to primitive value
751518c 
Related: neos#4619

Primitive values cannot be shown currently:

```
flow nodetypes:show Neos.Neos:Document --path properties.title.ui.label
Neos\ContentRepository\Command\NodeTypesCommandController_Original::truncateArrayAtLevel(): Argument neos#1 ($array) must be of type array, string given
```
jonnitto
jonnitto approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@jonnitto jonnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense 😄

@mhsdesign mhsdesign merged commit 1dab57e into neos:8.3 Feb 6, 2024
9 checks passed
@mhsdesign mhsdesign deleted the bugfix/nodeTypesCommandController-followup branch February 6, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnitto jonnitto jonnitto approved these changes

Assignees
No one assigned
Labels
8.3 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhsdesign @jonnitto