TASK: Fix MySQL migration differences on fresh setup #4236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hu i must have lost track of this :D Should we still target 7.3 (last bugfix) or rather 8.3 to be safe? |
|
I changed the base branch once, but could you please rebase on 8.3 and check if the pr is still correct ^^ |
|
Will check… |
kdambekalns
force-pushed
the
task/add-missing-migrations
branch
from
9edfda4 to
674d0e2
Compare
|
With 8.3 this now gives me: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates some differences in the actual vs the expected DB setup in a fresh
Neos 8.3 installation.
Fixes #3118 (at least partly.)
Review instructions
doctrine:migrationgenerateshould just sayNo changes detectedafter Neos has been set up.Checklist
Tests have been created, run and adjusted as neededFEATURE|TASK|BUGFIX!!!and have upgrade-instructions