TASK: Throw InvalidArgumentException as \Throwable is not caught …

…in tests > Type error: Neos\ContentRepository\Core\Tests\Behavior\Fixtures\PostalAddress::__construct(): Argument #1 ($streetAddress) must be of type string, null given
neos · Oct 21, 2024 · b235af6 · b235af6
1 parent 728b8bc
commit b235af6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/...Behavior/Features/02-NodeCreation/01-CreateNodeAggregateWithNode_ConstraintChecks.feature b/...Behavior/Features/02-NodeCreation/01-CreateNodeAggregateWithNode_ConstraintChecks.feature
@@ -182,4 +182,4 @@ Feature: Create node aggregate with node
       | nodeAggregateId       | "nody-mc-nodeface"                                           |
       | nodeTypeName          | "Neos.ContentRepository.Testing:NodeWithInvalidDefaultValue" |
       | parentNodeAggregateId | "lady-eleonode-rootford"                                     |
-    Then the last command should have thrown an exception of type "CallErrorException"
+    Then the last command should have thrown an exception of type "InvalidArgumentException"
diff --git a/Neos.ContentRepository.Core/Tests/Behavior/Fixtures/PostalAddress.php b/Neos.ContentRepository.Core/Tests/Behavior/Fixtures/PostalAddress.php
@@ -31,10 +31,10 @@ private function __construct(
     public static function fromArray(array $array): self
     {
         return new self(
-            $array['streetAddress'],
-            $array['postalCode'],
-            $array['addressLocality'],
-            $array['addressCountry']
+            $array['streetAddress'] ?? throw new \InvalidArgumentException('streetAddress is not set.'),
+            $array['postalCode'] ?? throw new \InvalidArgumentException('postalCode is not set.'),
+            $array['addressLocality'] ?? throw new \InvalidArgumentException('addressLocality is not set.'),
+            $array['addressCountry'] ?? throw new \InvalidArgumentException('addressCountry is not set.')
         );
     }