TASK: on formRuntime initialization do not overwrite formState values for non existend request arguments #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for non existend request arguments
daniellienert
approved these changes
Jun 7, 2022
|
This change introduced a severe breaking change that skips not-empty validation for radio buttons, checkboxes and file uploads (#157). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a form gets initialized with a form state from the URL's query parameter and this form contains a "lastDisplayedPage" the formState gets initialized correctly at first, but than the form framework tries to map the requests argument for the "lastDisplayedPage" to the formState. If the request does not contain these values the already in the formState present values get overwritten with null.
We would suggest to skip the initialization if an argument is not present at all.